Opened on 01/12/2016 at 04:40:12 PM
Closed on 01/12/2016 at 05:20:45 PM
Last modified on 01/18/2016 at 01:34:42 AM
#3504 closed defect (fixed)
Screenshot color reduction step of the Issue Reporter is very slow
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Environment
Adblock Plus 2.7.0.4123-beta, Firefox 46.0a1 nightly
How to reproduce
- Click ABP icon and "Report issue on this page" on some website.
Observed behaviour
Data collection hangs on a single step (screenshot color reduction), it takes 30 seconds to get past that.
Expected behaviour
Data collection shouldn't take that long.
Background
Going through a few million pixels doesn't take that much time. However, my testing revealed that accessing pixelData.data is very slow - caching that value causes the processing time to drop from 30 seconds to 3.5 seconds. I'm not sure why it only shows now, might be caused by some changes in Firefox and not on our end.
Attachments (0)
Change History (5)
comment:1 Changed on 01/12/2016 at 04:42:41 PM by trev
comment:2 Changed on 01/12/2016 at 05:20:45 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 01/12/2016 at 05:21:10 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
comment:4 Changed on 01/12/2016 at 05:21:26 PM by trev
- Component changed from Unknown to Adblock-Plus-for-Firefox
comment:5 Changed on 01/18/2016 at 01:34:42 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
No large delay noticed when processing screenshots.
ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 46.0a1 / Ubuntu 14.04 x64
Fixed: https://hg.adblockplus.org/adblockplus/rev/42d6eb983dff