Opened on 01/12/2016 at 04:06:55 PM
Closed on 01/12/2016 at 05:18:17 PM
Last modified on 01/18/2016 at 01:35:17 AM
#3503 closed defect (fixed)
Screenshot marker in Issue Reporter is no longer red
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-2.7.1-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
Adblock Plus 2.7.0.4123-beta
How to reproduce
- Click ABP icon and "Report issue on this page" on some website.
- Choose "Adblock Plus doesn't block an advertisement" in Issue Reporter and click Continue.
- Click somewhere in the screenshot and drag.
Observed behaviour
A black frame is being drawn, line width 1 pixel.
Expected behaviour
A red frame is being drawn, line width 3 pixels.
Background
This is a regression from #3486. Canvas context is initialized before canvas size is set. It seems that setting canvas size resets everything however.
Attachments (0)
Change History (3)
comment:1 Changed on 01/12/2016 at 04:12:26 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 01/12/2016 at 05:18:17 PM by trev
- Milestone set to Adblock-Plus-for-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 01/18/2016 at 01:35:17 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Frame is red again.
ABP 2.7.0.4128-beta
Firefox 38 / 43 / 44 / 46.0a1 / Ubuntu 14.04 x64
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/adblockplus/rev/fe4e4af5d17d