Opened on 04/17/2014 at 05:36:28 PM
Closed on 04/17/2014 at 07:34:42 PM
Last modified on 05/19/2014 at 05:51:21 PM
#354 closed defect (fixed)
Avoid toUpperCase call in filters
Reported by: | tschuster | Assignee: | tschuster |
---|---|---|---|
Priority: | P2 | Milestone: | Adblock-Plus-2.6-for-Firefox |
Module: | Core | Keywords: | |
Cc: | Blocked By: | #419 | |
Blocking: | Platform: | ||
Ready: | yes | Confidential: | no |
Tester: | Verified working: | no | |
Review URL(s): |
Description
That toUpperCase causes us to keep around the string twice. Once the original and once as upper-case. But we really only need it when something invokes the domain getter.
Attachments (0)
Change History (7)
comment:1 Changed on 04/17/2014 at 07:33:48 PM by tschuster
comment:2 Changed on 04/17/2014 at 07:34:29 PM by tschuster
- Owner set to tschuster
- Status changed from new to assigned
comment:3 Changed on 04/17/2014 at 07:34:42 PM by tschuster
- Resolution set to fixed
- Status changed from assigned to closed
comment:4 Changed on 04/22/2014 at 06:39:26 AM by trev
- Component changed from Unknown to Adblock-Plus-for-Firefox
- Milestone set to Adblock-Plus-for-Firefox-next
- Priority changed from Unknown to P2
- Ready set
comment:5 Changed on 05/05/2014 at 09:28:27 AM by trev
- Component changed from Adblock-Plus-for-Firefox to Core
comment:6 Changed on 05/05/2014 at 09:38:05 AM by trev
- Blocked By 419 added
comment:7 Changed on 05/19/2014 at 05:51:21 PM by tschuster
I tried to measure how much this actually helped, but sadly the string memory usage is so random it's hard to tell.
Note: See
TracTickets for help on using
tickets.
Landed
https://hg.adblockplus.org/adblockplus/rev/6bd8374f4ec7