Implement Chrome Web Store API in order to update the devbuild

[sebastian]

Background

We have to publish our devbuild in the Chrome Web Store (see #364), but want keep the devbuild automatically in sync with the content of the repository.

What to change

Use the ​Chrome Webstore API to automatically update the devbuild in the Web Store whenever a new devbuild is available.

[sebastian]

​https://hg.adblockplus.org/sitescripts/rev/6d19766d15ff

[trev]

This broke development build generation:

AttributeError: 'NightlyBuild' object has no attribute 'type'

Fixed it in ​https://hg.adblockplus.org/sitescripts/rev/75f3cfd0eb82

[trev]

Reopening: we need to specify a separate gallery ID for the devbuild upload (usual gallery ID is the stable version). Also, we need to make sure that the build isn't just uploaded but also published - currently it stays there as a draft.

[sebastian]

​https://hg.adblockplus.org/sitescripts/rev/ec38ae10dde7
​https://hg.adblockplus.org/sitescripts/rev/5ef24ac03872

[trev]

Reopening once again - while the draft upload succeeds now, publishing doesn't. The processing of the upload request overwrites the response variable, consequently the publish request fails when it tries to use response['token_type'].

[sebastian]

​https://hg.adblockplus.org/sitescripts/rev/554f3574668a

[trev]

Reopening once more - this time I got "400 Bad Request" from the publish request. Feel free to test your changes before uploading a review ;)

[sebastian]

That is not that easy, since I don't have access to our CWS account. I would have to publish a clone of Adblock Plus or at least a dummy extension with my personal CWS account, which would not only take a while to get published, but might also be against the CWS policy.

So could you please wrap the urlopen() call like following and post the error here? Thanks.

try:
   response = json.load(urllib2.urlopen(...))
except urllib2.HTTPError as e:
   print e.read()

[sebastian]

Apparently the publish URL was wrong. Should be fixed with the new patch. If you still get an error, please provide the error response body, since I can only hardly reproduce it myself.

[trev]

The error was: "reason":"badContent","message":"Unsupported content with type: application/octet-stream". Turned out the endpoint URL is wrong, it's https://www.googleapis.com/chromewebstore/v1.1/items/%s/publish - without upload.

After fixing this the upload succeeded but produced an exception with the status message OK - it seems that the documentation doesn't list all the possible statuses. So please extend the exception code there to report the actual status as well, next time we'll know what the Web Store returns on success.

Finally, please make sure to always report response body here to make debugging easier. Most clean solution should be implementing an own HTTPErrorProcessor class.

[sebastian]

I leave the ticket open, since we still have to figure out and add the status, that is returned when the item were successfuly published.

​https://hg.adblockplus.org/sitescripts/rev/d57a01bb362f
​https://hg.adblockplus.org/sitescripts/rev/3a02793b406a
​https://hg.adblockplus.org/sitescripts/rev/f02c4c3c2ad5

[trev]

There was a typo in one of the changes, the class is referred to as HTTPErrorHandler rather than HTTPErrorBodyHandler.

After fixing it, the exception is {'status': [u'OK'], 'statusDetail': [u'OK.']} - so the status is apparently indeed OK.

[sebastian]

​https://hg.adblockplus.org/sitescripts/rev/6da8b009f021
​https://hg.adblockplus.org/sitescripts/rev/bd02ab82a3cd