Opened on 01/26/2016 at 05:00:22 AM
Closed on 12/07/2016 at 08:05:35 PM
#3574 closed change (fixed)
Refactor Puppet class base into class adblockplus
| Reported by: | matze | Assignee: | matze |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | Blocked By: | #3818 | |
| Blocking: | #3576, #3638, #4004 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29334668 |
||
Description
Class base is always included by our node classifier, never by any other Puppet class. Thus the movement itself should be fairly trivial, though we may consider additional improvements now, i.e.:
- Remove the possibly obsolete conditional around the definition of class apt
- Avoid all explicit host records being realized due to Puppet issue 4145
Desired future improvements include:
- Avoid APT update being executed on every single Puppet run
- Remove private::users in favour of $adblockplus::users
- Improve the node classifier, especially handling of Hiera/$servers parameters
- Migrate base::explicit_host_record() into class adblockplus::host
This ticket is part of our long-term adventure of improving the infrastructure code-base.
Attachments (0)
Change History (31)
comment:1 Changed on 01/26/2016 at 05:12:56 AM by matze
- Blocking 3576 added
- Cc fred removed
- Ready set
comment:2 Changed on 01/27/2016 at 09:56:23 AM by matze
- Blocking 3587 added
comment:3 Changed on 01/27/2016 at 09:57:01 AM by matze
- Owner set to matze
comment:4 Changed on 01/27/2016 at 10:41:23 AM by matze
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 02/01/2016 at 11:48:06 AM by matze
comment:7 Changed on 02/07/2016 at 06:32:17 PM by matze
- Blocked By 3638 added
comment:8 Changed on 02/07/2016 at 06:58:17 PM by matze
- Blocked By 3638 removed
- Blocking 3638 added
- Review URL(s) modified (diff)
comment:9 Changed on 02/18/2016 at 12:38:55 PM by matze
comment:10 Changed on 03/06/2016 at 07:33:38 PM by matze
- Review URL(s) modified (diff)
comment:11 Changed on 03/07/2016 at 02:29:14 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/c87aa23fb276
comment:12 Changed on 03/08/2016 at 12:07:01 AM by matze
- Review URL(s) modified (diff)
comment:13 Changed on 03/09/2016 at 03:38:45 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/398e6fe0cd7d
comment:14 Changed on 03/09/2016 at 07:31:01 PM by matze
- Review URL(s) modified (diff)
comment:15 Changed on 03/16/2016 at 05:28:20 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/8a8f0de52ea1
comment:16 Changed on 03/16/2016 at 06:11:34 PM by matze
- Blocked By 3818 added
comment:17 Changed on 03/16/2016 at 09:51:29 PM by matze
- Review URL(s) modified (diff)
comment:18 Changed on 03/17/2016 at 02:40:56 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/eeb831ca03b6
comment:19 Changed on 03/29/2016 at 10:29:03 AM by matze
- Review URL(s) modified (diff)
The list of packages hard-coded within Class['base'] is about to become replaced by parameter $adblockplus::packages, combining functions hiera_array() and ensure_packages() to provide a more flexible approach.
comment:20 Changed on 03/31/2016 at 08:24:38 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/8b75b9ebf548
comment:21 Changed on 03/31/2016 at 08:46:19 PM by matze
- Blocking 3587 removed
comment:22 Changed on 04/25/2016 at 06:44:19 AM by matze
- Review URL(s) modified (diff)
comment:23 Changed on 04/25/2016 at 07:53:17 AM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/f5f2cdb46df8
comment:24 Changed on 04/28/2016 at 11:05:46 AM by matze
- Blocking 4004 added
comment:25 Changed on 12/01/2016 at 04:47:07 PM by matze
- Review URL(s) modified (diff)
comment:26 Changed on 12/05/2016 at 07:00:53 AM by abpbot
A commit referencing this issue has landed:
Issue 3574 - Remove obsolete sshkey realization class statsmaster
comment:27 Changed on 12/06/2016 at 10:41:28 AM by paco
- Review URL(s) modified (diff)
comment:28 Changed on 12/07/2016 at 10:10:19 AM by abpbot
A commit referencing this issue has landed:
Issue 3574 - Refactor Puppet class base into class adblockplus
comment:29 Changed on 12/07/2016 at 10:21:13 AM by matze
- Review URL(s) modified (diff)
comment:30 Changed on 12/07/2016 at 11:53:35 AM by abpbot
A commit referencing this issue has landed:
Issue 3574 - Update run.py to recognize adblockplus::host records
comment:31 Changed on 12/07/2016 at 08:05:35 PM by matze
- Resolution set to fixed
- Status changed from reviewing to closed
In order to remove blocking status for #3587, the first step is a simple inclusion of class base within class adblockplus (and updating base.yaml accordingly).