Opened on 01/27/2016 at 02:20:07 AM
Closed on 03/31/2016 at 08:46:19 PM
#3587 closed change (fixed)
Refactor Puppet class users into type adblockplus::user
| Reported by: | matze | Assignee: | matze |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Infrastructure | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #3576 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29334658 |
||
Description (last modified by matze)
With the introduction of parameter $adblockplus::users and type adblockplus::user in #3508, Puppet class users has been declared deprecated. The new one is currently implemented as a wrapper around the old, thus the first task will be migrating existing user accounts - before moving the actual code.
Attachments (0)
Change History (13)
comment:1 Changed on 01/27/2016 at 02:37:52 AM by matze
- Owner set to matze
- Ready set
comment:2 Changed on 01/27/2016 at 02:38:10 AM by matze
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 01/27/2016 at 09:56:23 AM by matze
- Blocked By 3574 added
- Blocking 3576 added
comment:5 Changed on 02/01/2016 at 11:27:04 AM by matze
comment:7 Changed on 02/07/2016 at 02:58:17 PM by matze
- Type changed from defect to change
comment:8 Changed on 02/18/2016 at 12:47:19 PM by matze
comment:9 Changed on 03/16/2016 at 06:31:52 PM by matze
comment:10 Changed on 03/17/2016 at 02:29:20 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/740cdf91d910
comment:11 Changed on 03/29/2016 at 08:59:03 AM by matze
- Review URL(s) modified (diff)
All remaining resources in Class['users'] are related to super-user access:
- File['/etc/sudoers.d/puppet']
- File['/root/.ssh/authorized_keys']
- User['root']
For those we'll introduce a "mixin" class adblockplus::sudo, transferring each file resources as-is, but replacing User['root'] (which ensures no password being set) with an ensure_dependencies() equivalent.
comment:12 Changed on 03/31/2016 at 08:43:20 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/infrastructure/rev/3d68e0339734
comment:13 Changed on 03/31/2016 at 08:46:19 PM by matze
- Blocked By 3574 removed
- Resolution set to fixed
- Status changed from reviewing to closed
https://hg.adblockplus.org/infrastructure/rev/ab0ece868ea4