Opened on 01/26/2016 at 05:01:51 PM
Closed on 02/17/2016 at 04:03:13 PM
Last modified on 02/17/2016 at 08:30:42 PM
#3584 closed defect (fixed)
[abp2blocklist] Element hiding rules with uppercase letters never apply
| Reported by: | sebastian | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Platform | Keywords: | 2016q1 |
| Cc: | kzar | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Background
If a rule's action.type is css-display-none and it's action.selector is a CSS selector that matches by ID using uppercase letters (e.g. #FooBar), it should hide elements like <div id="FooBar">. But due to a WebKit bug, that doesn't work.
If we use the attribute syntax like [id=FooBar] however it _does_ work, the rule will hide the element.
What to change
For each hiding rule, modify the selector to ensure that all IDs are specified with the [id=FooBar] syntax instead of the normal #FooBar syntax.
Attachments (0)
Change History (5)
comment:1 Changed on 02/16/2016 at 07:12:19 PM by kzar
- Owner set to kzar
comment:2 Changed on 02/16/2016 at 07:48:47 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 02/17/2016 at 04:03:13 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/abp2blocklist/rev/8cbce2943f02