Opened on 01/26/2016 at 05:10:09 PM

Closed on 02/17/2016 at 11:45:54 AM

Last modified on 03/07/2016 at 12:03:44 PM

#3585 closed change (fixed)

[abp2blocklist] Merge element hiding rules for the same domain

Reported by: sebastian Assignee: kzar
Priority: P2 Milestone:
Module: Platform Keywords: 2016q1
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29336349/

Description (last modified by sebastian)

Background

The maximum number of content blocker rules in iOS and Safari, is currently limited to 50,000. In order to comply with that limit we currently ignore element hiding filters. However, there is a way to significantly reduce the number of generated element hiding rules, by merging filters to be applied on the same domain using a comma-separated list of CSS selectors.

What to change

Group generic element hiding filters, as well as element hiding filters to be applied on the same domain, together, to generate fewer content blocker rules.

Remove the workaround that causes element hiding filters to be ignored.

Attachments (1)

easylist.json.gz (549.6 KB) - added by kzar on 02/13/2016 at 07:31:27 PM.
Content blocker list with grouped element hiding rules

Download all attachments as: .zip

Change History (11)

comment:1 Changed on 01/26/2016 at 05:29:15 PM by sebastian

  • Description modified (diff)

comment:2 Changed on 01/28/2016 at 04:25:33 PM by sebastian

  • Description modified (diff)

comment:3 Changed on 01/28/2016 at 04:35:01 PM by sebastian

  • Description modified (diff)

comment:4 Changed on 01/28/2016 at 04:49:51 PM by sebastian

  • Description modified (diff)

comment:5 Changed on 02/12/2016 at 02:09:20 PM by kzar

  • Cc kzar removed
  • Owner set to kzar

Changed on 02/13/2016 at 07:31:27 PM by kzar

Content blocker list with grouped element hiding rules

comment:6 Changed on 02/13/2016 at 07:34:26 PM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 02/16/2016 at 11:21:38 AM by sebastian

  • Description modified (diff)

comment:8 Changed on 02/17/2016 at 11:45:54 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed on 02/24/2016 at 12:58:29 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

The new grouped list is accepted by / works with the "Content Blocker" section of the Safari Extension Builder and installs with an extension.

Safari 9.0.3 / OS X 10.11.3

comment:10 Changed on 03/07/2016 at 12:03:44 PM by scheer

  • Also verified for ABP iOS. The new list works with ABP iOS and the test sheets for AA and top 50 Alexa were ran. Please do note the additional issues that were reported in those sheets, which can be found here and here.

ABP 1.1.0 (201601281708)
iPhone 6 Plus - iOS 9.2.1

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
 
Note: See TracTickets for help on using tickets.