Opened on 01/27/2016 at 02:47:50 PM

Closed on 01/12/2017 at 11:02:56 AM

#3591 closed change (rejected)

Support <template> on Safari <7 and Edge for new options page

Reported by: greiner Assignee:
Priority: P2 Milestone:
Module: User-Interface Keywords: 2016q1
Cc: sebastian, oleksandr Blocked By:
Blocking: #2706 Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description (last modified by sebastian)

Background

We're using <template> elements in various places in the new options page. Safari <7 and Edge doesn't support those, however. So we need to work around that limitation.

What to change

  • Hide <template> tags by default
  • Implement HTMLUnknownElement.content using DocumentFragment to polyfill HTMLTemplateElement.content

Attachments (0)

Change History (9)

comment:1 Changed on 02/26/2016 at 03:20:47 PM by greiner

  • Blocking 2706 added

comment:2 Changed on 03/02/2016 at 12:23:56 PM by sebastian

  • Description modified (diff)
  • Keywords edge added
  • Platform changed from Safari to Unknown / Cross platform
  • Summary changed from Support <template> on Safari 6.1-7.0 for new options page to Support <template> on Safari <7 and Edge for new options page

comment:3 follow-up: Changed on 03/02/2016 at 12:31:49 PM by oleksandr

comment:4 Changed on 03/02/2016 at 12:32:08 PM by oleksandr

  • Cc oleksandr added

comment:5 in reply to: ↑ 3 ; follow-up: Changed on 03/02/2016 at 12:41:51 PM by greiner

Replying to oleksandr:

<template> on Edge seems to be supported: https://dev.windows.com/en-us/microsoft-edge/platform/status/templateelement

That'd explain why window.HTMLTemplateElement is not defined in Edge 20.10240 (the one I tested) but not why <template>.content is also undefined. Any idea why that might be the case?

comment:6 Changed on 03/02/2016 at 12:54:08 PM by sebastian

After all, it shouldn't matter much, as we need that polyfill for Safari anyway. And instead for a particular browser and it's version, we should rather check for presence of HTMLTemplateElement.content anyway.

comment:7 in reply to: ↑ 5 Changed on 03/02/2016 at 10:11:28 PM by oleksandr

Replying to greiner:

That'd explain why window.HTMLTemplateElement is not defined in Edge 20.10240 (the one I tested) but not why <template>.content is also undefined. Any idea why that might be the case?

Both window.HTMLTemplateElement and document.createElement('template').content are defined starting from EdgeHTML 13 (November 2015). I've just checked, but it is also stated here

Note: referencing the Edge app version is advised against, since it is the underlying engine (EdgeHTML) that's important here.

comment:8 Changed on 05/23/2016 at 10:36:25 AM by sebastian

  • Keywords edge removed
  • Platform changed from Unknown / Cross platform to Edge

comment:9 Changed on 01/12/2017 at 11:02:56 AM by sebastian

  • Resolution set to rejected
  • Status changed from new to closed

With the traditional Adblock Plus Safari extension being phased out in favor of a native app, and Microsoft Edge seeming to support <template> natively meanwhile, this became unnecessary.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.