Opened on 01/29/2016 at 11:00:00 AM
Closed on 12/05/2016 at 02:43:17 PM
Last modified on 05/26/2017 at 01:54:29 PM
#3594 closed defect (fixed)
The circular reference problem, JsEngine<>-JsValue<>-JsEngine
| Reported by: | sergz | Assignee: | sergz |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | fhd, rjeschke, oleksandr, eric@…, Anton | Blocked By: | #4613 |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29361562/ |
||
Description
Background
The circular reference problem. AdblockPlus::JsEngine has member JsValuePtr globalJsObject; which has JsEnginePtr jsEngine; member.
What to change
Get rid of that circular reference.
Attachments (0)
Change History (7)
comment:1 Changed on 11/02/2016 at 03:19:25 PM by sergz
- Owner set to sergz
comment:2 Changed on 11/03/2016 at 11:30:58 AM by sergz
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 11/03/2016 at 12:44:26 PM by asmirnov
- Cc Anton added
comment:4 Changed on 11/07/2016 at 12:52:57 PM by sergz
- Blocked By 4613 added
comment:5 Changed on 12/02/2016 at 05:16:50 PM by eric@adblockplus.org
- Review URL(s) modified (diff)
comment:6 Changed on 12/05/2016 at 02:43:17 PM by eric@adblockplus.org
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 05/26/2017 at 01:54:29 PM by sergz
- Blocking 3593 removed
Note: See
TracTickets for help on using
tickets.
