Opened on 11/07/2016 at 12:52:57 PM

Closed on 11/21/2016 at 10:07:20 AM

#4613 closed change (fixed)

TimeoutThread is leaking

Reported by: sergz Assignee: sergz
Priority: P2 Milestone:
Module: Libadblockplus Keywords:
Cc: oleksandr, fhd Blocked By:
Blocking: #3594 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29361582/

Description

Background

TimeoutThread is not deleted.

In addition as a fix I would like to make a refactoring which should also help to delete Thread when known exception which can be ignored is thrown inside Thread::Run, it's actually a case of #3594.

What to change

Add a flag indicating whether the thread function should delete the instance of Thread or not and call delete thread from thread function CallRun in accordance with the flag value.

Attachments (0)

Change History (2)

comment:1 Changed on 11/21/2016 at 10:05:21 AM by abpbot

A commit referencing this issue has landed:
​Issue 4613 - fix leak of Thread

comment:2 Changed on 11/21/2016 at 10:07:20 AM by sergz

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from sergz.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.