Opened on 04/21/2014 at 07:12:21 AM
Closed on 08/18/2014 at 11:49:21 AM
Last modified on 08/25/2014 at 09:08:11 AM
#362 closed defect (fixed)
firefox: block image broken on youtube thumbnails (recommended videos)
| Reported by: | mapx | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-2.6.5-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | trev | Blocked By: | |
| Blocking: | #472 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by trev)
firefox 29 beta
ABP last dev build 2.5.1.3800
easylist
go to youtube main page
Recommended videos
right click on the thumbs ==> block image
the same filter is created for all the thumbnails:
||s.ytimg.com/yts/img/pixel-vfl3z5WfW.gif
ABP for chrome works correctly ==> different filters for different thumbs
What to change
- Introduce a sequential counter for the requests (request ID), each subsequent request should be associated with a higher request ID value.
- When retrieving the request associated with a node, use the one with the higher request ID if there are multiple.
Hints for testers
This change might also have an effect on the blockable items functionality in Firefox, this one should still work correctly.
Attachments (0)
Change History (14)
comment:1 Changed on 04/21/2014 at 07:14:54 AM by mapx
- Description modified (diff)
- Summary changed from firefox: block image broken on youtube to firefox: block image broken on youtube thumbnails (recommended videos)
comment:2 Changed on 04/22/2014 at 05:46:55 AM by trev
- Cc trev added
- Priority changed from P2 to P3
- Ready set
comment:3 Changed on 04/22/2014 at 07:55:12 AM by mapx
Like I said ABP for chrome manages to find the correct filter
comment:4 Changed on 04/22/2014 at 08:44:23 AM by trev
That's because ABP for Chrome doesn't record the loads in the first place - the functionality there is broken in a different way.
comment:5 Changed on 05/18/2014 at 08:09:07 AM by mapx
EHH is working fine (create the correct filter)
another report:
https://adblockplus.org/forum/viewtopic.php?p=99604#p99604
so, somebody needs to use EHH to find such a correct filter
comment:6 Changed on 05/19/2014 at 06:21:04 AM by trev
- Blocking 472 added
comment:8 Changed on 07/09/2014 at 12:38:11 PM by philll
- Platform set to Firefox
comment:9 Changed on 08/09/2014 at 07:45:50 PM by saroyanm
- Owner set to saroyanm
comment:10 Changed on 08/10/2014 at 12:25:33 PM by saroyanm
- Status changed from new to reviewing
comment:11 Changed on 08/10/2014 at 12:26:17 PM by saroyanm
- Review URL(s) modified (diff)
comment:12 Changed on 08/18/2014 at 11:49:21 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:13 Changed on 08/18/2014 at 12:25:44 PM by saroyanm
- Milestone set to Adblock-Plus-for-Firefox-next
comment:14 Changed on 08/25/2014 at 09:08:11 AM by trev
- Description modified (diff)
This is reproducible but not a regression, that's how Adblock Plus always worked. The problem is that two different images load for these thumbnails - first the pixel that is common for all of them, then the actual image. Adblock Plus doesn't distinguish between the two loads and offers you one of them "randomly". We should probably prefer whichever entry was recorded last.