Opened on 05/13/2014 at 11:36:50 AM
Closed on 11/10/2017 at 11:15:18 AM
#472 closed change (rejected)
Issue reporter - Asking the user to reload the page if issue is due to ABP starting late
| Reported by: | Crits | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | smultron45@gmail.com, trev, famlam | Blocked By: | #362 |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by mapx)
Background
Starting from ABP for Firefox 2.6, ABP start is delayed when Firefox starts, letting a few ads slip through. ABP start is planned to be sped up in the future, but it's likely it will still not have time to block a few undesirable requests.
However, many users are reporting ads through the issue reporter, not because of a filter issue, but because ABP had started late (and they are not bound to know that). Issue reports are thus quickly clogged by useless reports, and it can be pretty long to diagnose that the issue comes from #418 for these reports.
And I'm pretty sure this problem will last for long.
What to change
I had an idea on how to implement a solution:
- When the user report an issue, the issue reporter should take all the requests the webpage has already sent and make them go through ABP filters once again
- If after that the number of filtered requests is strictly superior to the number of previously blocked requests, then the issue reporter should ask the user to reload the page before trying again.
Attachments (0)
Change History (7)
comment:1 Changed on 05/13/2014 at 12:19:44 PM by mapx
- Cc smultron45@gmail.com added
comment:2 Changed on 05/14/2014 at 09:30:16 AM by Crits
comment:4 Changed on 05/19/2014 at 06:21:04 AM by trev
- Blocked By 362 added
- Cc trev added
- Priority changed from Unknown to P3
- Ready set
Our content policy seems to indeed start up immediately, before the filters load. This means that Adblock Plus will see the requests happening at startup even though it doesn't block them.
#362 requires implementing some kind of "timestamp" to assign to requests (or rather a sequential counter). We can then save the "timestamp" of the last configuration change - be it filters loading or a whitelist filter added/removed. If we see that a request has a smaller timestamp than the last configuration change we can show an error page asking the user to reload page.
comment:5 Changed on 07/03/2014 at 01:12:23 PM by arthur
- Cc famlam added
- Platform set to Unknown
comment:6 Changed on 07/09/2014 at 12:38:11 PM by philll
- Platform changed from Unknown to Firefox
comment:7 Changed on 11/10/2017 at 11:15:18 AM by trev
- Resolution set to rejected
- Status changed from new to closed
Mass-closing all bugs in Adblock Plus for Firefox module, the codebase of Adblock Plus 3.0 belongs into Platform and User-Interface modules. Old bugs are unlikely to still apply.
...small typing mistake in What to change, 1.
"should take that the webpage has already sent" => "should take all the requests the webpage has already sent"