Opened on 02/15/2016 at 02:47:34 PM
Closed on 02/24/2016 at 10:04:07 AM
Last modified on 02/25/2016 at 11:46:11 AM
#3655 closed defect (fixed)
Adblock Browser 1.3.0 shows empty blocking list on iOS 8.4.x
| Reported by: | pavelz | Assignee: | |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Browser-for-iOS-1.3.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
iOS 8.4.x
Adblock Browser 1.3.0 814
How to reproduce
- Load the browser
- Open Settings > Adblock Plus > Ad Blocking
Observed behaviour
The list of language subscriptions is empty. The browser is not blocking any ads.
Expected behaviour
The list shows language subscriptions with English selected. The browser blocks ads as expected
Attachments (0)
Change History (6)
comment:1 Changed on 02/15/2016 at 02:49:45 PM by pavelz
comment:2 Changed on 02/15/2016 at 02:50:04 PM by pavelz
Proposed fix
https://bitbucket.org/adblockplus/adblockplusadblockbrowserios/pull-requests/1/replaced-children-with/diff
use getElementsByTagName instead - which is what what background.js uses in addSubscription
Last edited on 02/15/2016 at 02:50:58 PM
by pavelz
comment:3 Changed on 02/16/2016 at 09:48:45 AM by mario
- Ready set
comment:4 Changed on 02/24/2016 at 10:04:07 AM by pavelz
- Resolution set to fixed
- Status changed from new to closed
Fixed in build 835 and later
comment:5 Changed on 02/24/2016 at 12:51:36 PM by pavelz
- Milestone set to Adblock-Browser-for-iOS-next
comment:6 Changed on 02/25/2016 at 11:46:11 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- All available Easylist languages are available in Settings>Adblock Plus>Ad Blocking and the first subscription shown is English and is active.
- The browser blocks ads as expected.
ABB 1.3.0-qa (836)
iPhone 6 Plus - iOS 9.2.1
Note: See
TracTickets for help on using
tickets.
The new ABB API integration
https://bitbucket.org/adblockplus/adblockplusadblockbrowserios/src/5385640706f189b9a0d1c036f2df10d9912538e3/api.js?fileviewer=file-view-default#api.js-29
expects Element.prototype.children to be implemented. WebKit on iOS 8.4.x implements only HTMLElement.prototype.children but not the generic Element (which is a result of XMLParser). As a result the above line returns null and no language subscriptions are ever loaded -> not displayed, not usable for blocking