Opened on 02/15/2016 at 12:49:31 PM
Closed on 02/16/2016 at 02:06:55 PM
Last modified on 02/16/2016 at 02:58:36 PM
#3654 closed defect (fixed)
CSS property filter prefix and suffix improperly applied
| Reported by: | greiner | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.11-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, kzar, arthur, scuturic | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29336406 |
||
Description
Environment
Ubuntu 14.04
Chrome 48
Adblock Plus 1.10.2.1550
How to reproduce
- Add custom filter focus.de###sidebar [-abp-properties='margin-left: 1*px;']
- Go to http://www.focus.de
Observed behavior
A CSS rule with the following selectors is added:
#sidebar .grid_1, .grid_2, .grid_3, .grid_4, .grid_5, .grid_6, .grid_7, .grid_8, .grid_9, .grid_10, .grid_11, .grid_12
Expected behavior
A CSS rule with the following selectors is added:
#sidebar .grid_1, #sidebar .grid_2, #sidebar .grid_3, #sidebar .grid_4, #sidebar .grid_5, #sidebar .grid_6, #sidebar .grid_7, #sidebar .grid_8, #sidebar .grid_9, #sidebar .grid_10, #sidebar .grid_11, #sidebar .grid_12
Attachments (0)
Change History (5)
comment:1 Changed on 02/15/2016 at 01:30:40 PM by arthur
- Cc scuturic added
comment:2 Changed on 02/15/2016 at 03:40:19 PM by sebastian
- Owner set to sebastian
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 02/15/2016 at 05:35:57 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 02/16/2016 at 02:06:55 PM by sebastian
- Component changed from Core to Platform
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 02/16/2016 at 02:58:36 PM by greiner
- Verified working set
I can confirm that with those changes the issue no longer occurs.
Note: See
TracTickets for help on using
tickets.
https://hg.adblockplus.org/adblockpluscore/rev/4f1d2c299c10
https://hg.adblockplus.org/adblockpluschrome/rev/928534250b96