Opened on 02/16/2016 at 10:38:38 AM
Closed on 02/17/2016 at 04:38:03 PM
Last modified on 04/22/2016 at 02:39:03 PM
#3659 closed change (fixed)
Remove locale dependency from filter classes
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | sebastian, fhd | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Background
Filter classes currently use localized strings for various parsing errors, this makes for ugly dependencies.
What to change
Make InvalidFilter store an error ID, not the actual error text, similarly to how synchronizer does it. Converting the error ID into a localized string should be done by the UI.
Integration notes
With this change InvalidFilter.reason will be an error (string) ID, not localized text any more. Two new translatable strings have to be added, we didn't localize these reasons before: filter_unknown_option ("Unknown filter option") and filter_invalid_regexp ("Invalid regular expression").
Attachments (0)
Change History (4)
comment:1 Changed on 02/16/2016 at 11:48:57 AM by trev
comment:2 Changed on 02/16/2016 at 11:49:17 AM by trev
- Cc sebastian fhd added
comment:3 Changed on 02/17/2016 at 04:38:03 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 04/22/2016 at 02:39:03 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Filter errors still work as expected.
ABP 2.7.2.4166
Firefox 38 / 44 / 45 / Windows 8
Firefox 38 / 44 / OSX 10.11
Firefox 44 / Ubuntu 14.04
Fixed: https://hg.adblockplus.org/adblockpluscore/rev/7307f14d4df9