Opened on 02/16/2016 at 11:53:43 AM
Closed on 02/19/2016 at 05:55:45 PM
Last modified on 04/22/2016 at 02:44:08 PM
#3660 closed change (fixed)
Remove locale dependency from subscription classes
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | sebastian, fhd | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Background
Subscription classes will currently use localized strings for default subscription titles, this makes for ugly dependencies.
What to change
Make subscription classes leave title empty if none is set. Showing default title instead of the empty one should be left to the UI code.
Integration notes
UI will have to deal with empty subscription titles now. Also, this change removes DownloadableSubscription.upgradeRequired field, version comparison between DownloadableSubscription.requiredVersion and current version has to be done in the UI now.
Attachments (0)
Change History (5)
comment:1 Changed on 02/16/2016 at 11:54:02 AM by trev
- Cc sebastian fhd added
comment:2 Changed on 02/16/2016 at 12:24:35 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 02/19/2016 at 05:55:45 PM by trev
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 04/22/2016 at 02:44:08 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
This change looks to be working as expected. I couldn't see/trigger any obvious problems with subscription titles,
ABP 2.7.2.4166
Firefox 38 / 44 / 45 / Windows 8
Firefox 38 / 44 / OSX 10.11
Firefox 44 / Ubuntu 14.04
Fixed: https://hg.adblockplus.org/adblockpluscore/rev/3b518ca1bfcc