Opened on 02/16/2016 at 02:30:31 PM

Closed on 02/16/2016 at 02:31:35 PM

Last modified on 02/24/2016 at 12:40:43 PM

#3661 closed change (fixed)

Update buildtools dependency to revision 9f83ac702260

Reported by: trev Assignee: trev
Priority: P4 Milestone: Adblock-Plus-2.7.2-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description

Background

The buildtools changes have no impact on the build whatsoever, I verified that an identical build is generated before and after this change. However, #3615 improves documentation generation. All other changes (#3498, #3515, #3516, #3532, #3404, #1740, #2109) should be irrelevant for Adblock Plus for Firefox.

What to change

Updating the dependency should be sufficient.

Attachments (0)

Change History (2)

comment:1 Changed on 02/16/2016 at 02:31:35 PM by trev

  • Milestone set to Adblock-Plus-2.7.2-for-Firefox
  • Resolution set to fixed
  • Status changed from new to closed

Fixed: ​https://hg.adblockplus.org/adblockplus/rev/52385513f941

comment:2 Changed on 02/24/2016 at 12:40:43 PM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Marking verified as changes have not caused any adverse effects / ABP is still working as expected.

ABP 2.7.2
Firefox 38.0 / Firefox 46.0a1 (Nightly) / Ubuntu 14.04 x64
Firefox 38.0 / Firefox 43.0.1 / Firefox 46.0a1 (Nightly) / Windows 7 x64

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.