Opened on 02/24/2016 at 11:45:05 PM
Closed on 03/10/2016 at 02:36:03 PM
Last modified on 09/20/2017 at 09:40:24 AM
#3695 closed change (fixed)
Edge exposes it's API with the "browser" namespace instead "chrome"
| Reported by: | sebastian | Assignee: | oleksandr |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | scottlow | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
Microsoft Edge is going to support a subset of the Chrome extension API. However, same as for Mozilla's Web Extensions, the namespace will be browser instead chrome.
As browser seems to become a standard, we might want to consider using it directly in the future, but as we have to develop compatibility changes for Edge in a fork for now, let's keep the change as small as possible.
What to change
Alias window.browser to window.chrome if it doesn't exist.
Attachments (0)
Change History (7)
comment:1 Changed on 03/10/2016 at 02:35:06 PM by sebastian
- Owner set to oleksandr
- Review URL(s) modified (diff)
comment:2 Changed on 03/10/2016 at 02:36:03 PM by sebastian
- Resolution set to fixed
- Status changed from new to closed
comment:3 Changed on 05/07/2016 at 01:32:41 AM by sebastian
- Cc scottlow added
comment:4 Changed on 05/23/2016 at 10:36:25 AM by sebastian
- Keywords edge removed
- Platform changed from Unknown / Cross platform to Edge
comment:5 Changed on 06/10/2016 at 11:27:49 PM by sebastian
- Sensitive unset
comment:6 Changed on 11/08/2016 at 12:24:18 PM by abpbot
A commit referencing this issue has landed:
Issue 3695 - Edge exposes it's API with the "browser" namespace
comment:7 Changed on 09/20/2017 at 09:40:24 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Tested through general use and checking that window.chrome exists in console in Edge/FF.
ABP 0.9.11.1849
Edge 40 / Windows 10
ABP 1.13.3.1838
Chrome 49 / 61 / Windows 10
Opera 36 / 47 / Windows 10
ABP 2.99.0.1838beta
Firefox 53 / 55 / Windows 10
https://bitbucket.org/sebastian_noack/adblockplusedge/commits/ad1653dc90b195e3f500269b64b6149cf2d07c88