Opened on 02/24/2016 at 11:50:34 PM
Closed on 03/14/2016 at 02:37:28 PM
Last modified on 11/08/2016 at 12:24:19 PM
#3696 closed change (fixed)
Fall back to tabs.create if windows.create isn't available
| Reported by: | sebastian | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | kzar, scottlow | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
With #2426 we started to show the "Block element" dialog as a popup using chrome.windows.create. Edge, however, won't support browser.windows.create from the beginning. So we need a fallback there.
What to change
Don't call chrome.windows.create if not available, fall back to opening a new tab (as we do on Safari).
Attachments (0)
Change History (6)
comment:1 Changed on 03/14/2016 at 07:59:07 AM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/14/2016 at 02:37:28 PM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
comment:3 Changed on 05/07/2016 at 01:32:41 AM by sebastian
- Cc scottlow added
comment:4 Changed on 05/23/2016 at 10:36:25 AM by sebastian
- Keywords edge removed
- Platform changed from Unknown / Cross platform to Edge
comment:5 Changed on 06/10/2016 at 11:27:49 PM by sebastian
- Sensitive unset
comment:6 Changed on 11/08/2016 at 12:24:19 PM by abpbot
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 3696 - Fall back to tabs.create if windows.create isn't available