Opened on 02/26/2016 at 09:00:09 PM

Closed on 02/26/2016 at 09:19:43 PM

#3709 closed defect (fixed)

[abp2blocklist] Filters aren't normalized before parsing

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: Platform Keywords: abp2blocklist
Cc: sebastian Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29337800/

Description (last modified by sebastian)

Background

The abp2blocklist command line script doesn't normalize the filters to be converted before parsing them. This is causing an inconsistency with Adblock Plus which normalizes all filters when the subscription got downloaded. So trailing spaces for example are ignored in Adblock Plus, but considered part of the filter here.

What to change

Take care to call Filter.normalize on the filter text before passing it to Filter.fromText in the abp2blocklist.js script.

Attachments (0)

Change History (2)

comment:1 Changed on 02/26/2016 at 09:15:11 PM by sebastian

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set
  • Summary changed from [abp2blocklist] abp2blocklist script is not normalising filters to [abp2blocklist] Filters aren't normalized before parsing

comment:2 Changed on 02/26/2016 at 09:19:43 PM by kzar

  • Resolution set to fixed
  • Review URL(s) modified (diff)
  • Status changed from new to closed

​https://hg.adblockplus.org/abp2blocklist/rev/1ddc05d359ce

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.