Opened on 02/26/2016 at 10:02:31 PM
Closed on 03/08/2016 at 12:58:39 PM
#3710 closed change (fixed)
[abp2blocklist] Unify hostname logic
| Reported by: | sebastian | Assignee: | kzar |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | kzar | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Background
Since #3670, the state machine converting filter patterns to regular expressions, also detects hostnames in order to make filters case sensitive when possible.
However, in order to convert IDN hostnames to punycode we still rely on following regexp:
/^(\|\||\|?https?:\/\/)([\w\-.*\u0080-\uFFFF]+)/i
Besides that regular expression not being completely accurrate, we shouldn't have redundant logic to identify hostnames.
What to change
Move the logic to encode domains as punycode to the state machine converting filters to regular expressions.
Attachments (0)
Change History (4)
comment:1 Changed on 02/27/2016 at 02:30:01 PM by kzar
comment:2 Changed on 02/27/2016 at 02:30:11 PM by kzar
- Status changed from new to reviewing
comment:3 Changed on 03/08/2016 at 12:48:17 PM by abpbot
comment:4 Changed on 03/08/2016 at 12:58:39 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
https://hg.adblockplus.org/abp2blocklist/rev/349d23311c0c