Opened on 03/04/2016 at 05:04:41 PM
Closed on 03/14/2016 at 04:29:47 PM
#3736 closed defect (fixed)
Regression: Check for blocked social resources fails
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | saroyanm | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Environment
Chrome 49.0.2623.75 (64-bit)
Adblock Plus 1.10.2
How to reproduce
- Open first-run page
- Enable "Remove social media buttons" feature
- Click on Twitter button in share section
Observed behaviour
Overlay is loaded and content fails to load.
Expected behaviour
https://twitter.com/adblockplus opens in a new tab.
Background
This is caused by a change in the function signature of Matcher.matchesAny() (see #2738). Previously, it accepted the request type to be specified as a string (e.g. "SCRIPT") but now it only accepts a number (e.g. RegExpFilter.typeMap["SCRIPT"]).
What to change
Change
defaultMatcher.matchesAny(..., message.requestType, ...)
to
defaultMatcher.matchesAny(..., RegExpFilter.typeMap[message.requestType], ...)
in messageResponder.js
Attachments (0)
Change History (6)
comment:1 Changed on 03/04/2016 at 05:15:45 PM by greiner
- Owner set to greiner
comment:3 Changed on 03/04/2016 at 05:25:12 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 03/04/2016 at 05:27:18 PM by greiner
- Ready set
comment:5 Changed on 03/14/2016 at 04:29:01 PM by abpbot
comment:6 Changed on 03/14/2016 at 04:29:47 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/da160389eb39