Opened on 03/04/2016 at 06:50:39 PM

Closed on 05/03/2016 at 12:42:55 PM

Last modified on 05/23/2016 at 10:36:25 AM

#3737 closed change (fixed)

[logprocessor] Parse user agent strings from MS Edge

Reported by: sebastian Assignee: kvas
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: trev Blocked By:
Blocking: Platform: Edge
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340823/

Description

Background

The logprocessor currently doesn't handle Edge, when identifying the browser, presumably recognizing it as Chrome since Edge uses a similar user agent string.

What to change

Make the logprocessor identify requests from MS Edge. For reference, the user agent strings of Edge is based on one from Chrome, but add and Edge/ token to the end.

Attachments (0)

Change History (5)

comment:1 Changed on 04/25/2016 at 01:28:20 PM by kvas

  • Owner set to kvas

comment:2 Changed on 04/29/2016 at 12:27:13 PM by kvas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 05/03/2016 at 12:35:18 PM by abpbot

A commit referencing this issue has landed:
https://hg.adblockplus.org/sitescripts/rev/1d748c6ebc9e

comment:4 Changed on 05/03/2016 at 12:42:55 PM by kvas

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 05/23/2016 at 10:36:25 AM by sebastian

  • Keywords edge removed
  • Platform changed from Unknown / Cross platform to Edge

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kvas.
 
Note: See TracTickets for help on using tickets.