Opened on 03/07/2016 at 02:56:19 PM

Closed on 03/07/2016 at 03:00:17 PM

Last modified on 04/25/2016 at 02:44:25 AM

#3746 closed change (fixed)

Update Adblock Plus dependency on buildtools to revision c92cc4e4a338

Reported by: trev Assignee: trev
Priority: P2 Milestone: Adblock-Plus-2.7.3-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords:
Cc: Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

Description

Background

We fixed #2850 which affects Adblock Plus extension. This dependency update will import an additional change (#3704) which shouldn't have any impact on the Firefox build however.

What to change

After updating dependency prefs.json has to be moved from default/ to lib/.

Attachments (0)

Change History (3)

comment:1 Changed on 03/07/2016 at 02:58:16 PM by abpbot

A commit referencing this issue has landed:
​https://hg.adblockplus.org/adblockplus/rev/c56649c922b3

comment:2 Changed on 03/07/2016 at 03:00:17 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from new to closed

comment:3 Changed on 04/25/2016 at 02:44:25 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

#2850 is fixed and the change doesn't look to have introduced any obvious regressions.

ABP 2.7.2.4166
Firefox 38 / 44 / Windows 8
Nightly 48.0a1 (2016-04-19) / Windows 8
Firefox 38 / 44 / OS X 10.11
Firefox 45.01 / Ubuntu 14.04
Nightly 48.0a1 (2016-04-19) / Ubuntu 14.04

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.