Opened on 03/07/2016 at 03:04:04 PM
Closed on 03/07/2016 at 03:11:12 PM
Last modified on 05/02/2016 at 07:49:05 PM
#3747 closed change (fixed)
Update Element Hiding Helper dependency on buildtools to revision c92cc4e4a338
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | Element-Hiding-Helper-1.3.8 |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Background
We fixed #2850 which affects Element Hiding Helper extension as well. This dependency update will import additional changes however:
- #3490 - multiprocessCompatible flag added to manifest
- #3498, #3516, #3515, #3532, #1740, #3615, #2109, #3704 - shouldn't have any impact
What to change
After updating dependency prefs.json has to be moved from default/ to lib/. Also, we will have to add needMultiprocessShims=true to the manifest (EHH isn't E10S-compatible).
Attachments (0)
Change History (4)
comment:2 Changed on 03/07/2016 at 03:10:18 PM by abpbot
comment:3 Changed on 03/07/2016 at 03:11:12 PM by trev
- Milestone set to Element-Hiding-Helper-next
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed on 05/02/2016 at 01:36:09 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Working in both E10S and non-E10S Firefox with no obvious regressions.
ABP 2.7.3 / EHH 1.3.7.530
Firefox 38 / 44 / 45 / Nightly 49.0a1 / Windows 7
Firefox 38 / 44 / 45 / OS X 10.11
Firefox 38 / 44 / 45 / Nightly 49.0a1 / Ubuntu 14.04
Last edited on 05/02/2016 at 07:49:05 PM
by Ross
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
https://hg.adblockplus.org/elemhidehelper/rev/164aadf1a493