Opened on 03/07/2016 at 03:15:38 PM
Closed on 03/14/2016 at 02:20:53 PM
Last modified on 05/02/2016 at 07:51:25 PM
#3748 closed change (fixed)
Update URL Fixer dependency on buildtools to revision c92cc4e4a338
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P2 | Milestone: | URL-Fixer-4.1.2 |
| Module: | URL-Fixer | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
We fixed #2850 which affects URL Fixer extension as well. This dependency update will import additional changes however:
- #3490 - needMultiprocessShims flag added to manifest
- #3498, #3516, #3515, #3532, #1740, #3615, #2109, #3704 - shouldn't have any impact
What to change
After updating dependency prefs.json has to be moved from default/ to lib/, typoRules.json has to be moved from default/ to chrome/content. Also, we will need to check whether the extension works correctly in E10S mode.
Attachments (0)
Change History (4)
comment:1 Changed on 03/07/2016 at 08:25:36 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/14/2016 at 02:20:23 PM by abpbot
comment:3 Changed on 03/14/2016 at 02:20:53 PM by trev
- Milestone set to URL-Fixer-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/02/2016 at 07:51:25 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Working in both E10S and non-E10S Firefox with no obvious regressions.
ABP 2.7.3 / URLFixer 4.1.1.317
Firefox 38 / 44 / 45 / Nightly 49.0a1 / Windows 7
Firefox 38 / 44 / 45 / OS X 10.11
Firefox 38 / 44 / 45 / Nightly 49.0a1 / Ubuntu 14.04
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
https://hg.adblockplus.org/urlfixer/rev/85dfdb402703