Opened on 03/08/2016 at 04:52:45 PM
Closed on 03/09/2016 at 10:11:46 AM
Last modified on 03/14/2016 at 11:43:37 AM
#3760 closed change (fixed)
Remove the "opera" build target
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P3 | Milestone: | Adblock-Plus-1.12-for-Chrome-Opera-Safari |
| Module: | Automation | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://codereview.adblockplus.org/29337971 |
||
Description
Background
Historically, we have seperate builds for Chrome and Opera. That was because early Chromuim-based versions of Opera still had quite some differences requiring changes to the build. However, meanwhile our Chrome and Opera builds are identical, except for the browser name mentioned in the short description which can just be changed. So we don't need to support a separate build target for Opera anymore, but can simply provide the same builds as for Chrome.
What to change
- Merge the short description of Adblock Plus for Chrome, Opera and Safari
- Remove support for ./build.py -t opera
Attachments (0)
Change History (5)
comment:1 Changed on 03/08/2016 at 04:56:44 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/09/2016 at 10:03:50 AM by abpbot
comment:3 Changed on 03/09/2016 at 10:06:05 AM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluschrome/rev/dd7d4352824f
comment:4 Changed on 03/09/2016 at 10:11:46 AM by sebastian
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 03/14/2016 at 11:42:19 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Works as expected. The Opera specific target has been removed and building/installing Chrome/Opera builds as described in the README.
adblockpluschrome / 37693c923e69
A commit referencing this issue has landed:
https://hg.adblockplus.org/buildtools/rev/dbc98c6fc5bc