Opened on 03/09/2016 at 08:14:12 AM
Closed on 03/09/2016 at 03:20:24 PM
Last modified on 03/22/2016 at 03:38:08 PM
#3761 closed change (fixed)
Don't clear user input when filter validation failed on the new options page
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner | Blocked By: | |
| Blocking: | #3763 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29338005 |
||
Description
Background
While the old options page and the "Block element" dialog preserves user input when filter validation failed, the new options page currently clears the user input regardless of errors.
This is a user experience regression. When you typed some filter(s) which couldn't be saved due to a typo, you want to simply fix that issue, and not enter everything over again.
What to change
Instead emitting app.error when filter validation failed, always respond to the original message indicating errors if any. The UI code should then handle the response and only clear input or leave editing mode if the filters were added successfully.
Attachments (0)
Change History (7)
comment:1 Changed on 03/09/2016 at 08:15:08 AM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 03/09/2016 at 08:29:40 AM by sebastian
- Blocking 3763 added
comment:3 Changed on 03/09/2016 at 03:08:10 PM by greiner
- Ready set
comment:4 Changed on 03/09/2016 at 03:18:41 PM by abpbot
comment:5 Changed on 03/09/2016 at 03:20:24 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 03/22/2016 at 03:38:08 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/e6bca33c2837
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/e23fe878fabb