Opened on 03/16/2016 at 02:50:53 PM

Closed on 01/04/2019 at 10:50:01 AM

#3816 closed change (rejected)

Add experimental support for the new options page in Adblock Plus for Chrome, Opera and Safari

Reported by: kzar Assignee:
Priority: P2 Milestone:
Module: Platform Keywords:
Cc: sebastian, greiner Blocked By: #3968
Blocking: Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29340749/

Description (last modified by kzar)

Background

We're working on a new options page which should provide a much nicer user experience than the existing one. It is also to be standardised across our extensions and therefore live in the adblockplusui repository.

Work on the new options page continues, while it's not ready for end users we do want to begin using it for development and QA.

What to change

  • Integrate the new options page into adblockpluschrome but leave it unused by default.
  • Add a new preference, (with no corresponding toggle in the options page) that allows for the new options page to be enabled.

Attachments (0)

Change History (10)

comment:1 Changed on 03/16/2016 at 02:53:18 PM by kzar

  • Summary changed from Use new options page in Adblockplus for Chrome, Opera and Safari to Use new options page in Adblock Plus for Chrome, Opera and Safari

comment:2 Changed on 03/24/2016 at 12:06:42 PM by kzar

  • Blocking 3687 removed

comment:3 Changed on 04/18/2016 at 05:51:35 PM by kzar

  • Description modified (diff)
  • Summary changed from Use new options page in Adblock Plus for Chrome, Opera and Safari to Add experimental support for the new options page in Adblock Plus for Chrome, Opera and Safari

comment:4 Changed on 04/21/2016 at 02:23:00 PM by kzar

  • Blocked By 2706 removed
  • Owner set to kzar

Since this ticket is to now add support for the new options page as a hidden feature I guess it's no longer blocked by #2706. I'll make a start on this now, it will make my life easier doing further work on the new options page if nothing else.

comment:5 Changed on 04/21/2016 at 03:32:50 PM by kzar

  • Blocked By 3967 added

comment:6 Changed on 04/21/2016 at 05:33:39 PM by kzar

  • Blocked By 3968 added

comment:7 Changed on 04/21/2016 at 05:38:03 PM by kzar

  • Blocked By 3967 removed

comment:8 Changed on 04/22/2016 at 09:34:55 AM by kzar

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:9 Changed on 12/12/2016 at 11:32:11 AM by kzar

  • Owner kzar deleted

comment:10 Changed on 01/04/2019 at 10:50:01 AM by kzar

  • Resolution set to rejected
  • Status changed from reviewing to closed

Since we've already added the new options page some time ago I'm closing this.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.