Opened on 04/21/2016 at 05:33:39 PM
Closed on 04/22/2016 at 12:40:44 PM
#3968 closed change (fixed)
Rename options.{html,css,js} to new-options.{html,css,js}
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | sebastian, greiner | Blocked By: | |
| Blocking: | #3816 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In issue #3816 we're adding experimental support for the new options page into Adblock Plus for Chrome, Opera and Safari. Users will still use the old options page but this way we'll be able to use the new options page for development and QA purposes.
As both the old and new options page will be supported by the extension some of the filenames are going to clash, for example options.html.
What to change
Rename options.html, options.js and options.css to new-options.html, new-options.js and new-options.css respectively. Change any references to those filenames where necessary so that everything continue to work as before.
Attachments (0)
Change History (6)
comment:1 Changed on 04/21/2016 at 05:36:20 PM by kzar
comment:2 Changed on 04/21/2016 at 06:06:14 PM by greiner
- Priority changed from Unknown to P2
- Ready set
Maybe at some point we could have separate metadata.* files for devbuilds to avoid those conflicts but I assume that'd be too much work for now so fine with me.
comment:3 Changed on 04/21/2016 at 06:08:10 PM by kzar
- Owner set to kzar
comment:4 Changed on 04/22/2016 at 09:22:45 AM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 04/22/2016 at 12:39:15 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/47d8c208c3e9
comment:6 Changed on 04/22/2016 at 12:40:44 PM by kzar
- Resolution set to fixed
- Status changed from reviewing to closed
What do you think Thomas?
Me and Sebastian discussed the various options for getting the new options page working in adblockpluschrome and this seemed the simplest/cleanest. If you're OK with it I'll happily assign myself and make the changes.