Opened on 03/17/2016 at 01:06:02 PM
Closed on 10/17/2016 at 03:08:33 PM
Last modified on 06/19/2017 at 12:10:20 PM
#3820 closed defect (fixed)
Selecting Settings within ABB for Android causes the app to crash.
| Reported by: | scheer | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.2.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #2512, #4237 | Platform: | Adblock Browser for Android |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description
If the user attempts to open Settings whilst on a website or in the dashboard, the app crashes.
Environment
adblockbrowser-1.1.1-42.0.2-20160317113800-testing
Samsung Galaxy S6 - Android 6.0
How to reproduce
- Open the app and select Options from the top right
- Select Settings
Observed behaviour
The app crashes with the error message 'Unfortunately, Adblock Browser has stopped'.
Expected behaviour
The user is taken to the settings page.
Attachments (1)
Change History (15)
comment:1 Changed on 03/17/2016 at 05:38:15 PM by mapx
- Component changed from Adblock-Plus-for-Android to Adblock-Browser-for-Android
comment:2 Changed on 03/18/2016 at 11:34:02 AM by rjeschke
- Priority changed from Unknown to P2
- Ready set
comment:3 Changed on 03/18/2016 at 11:35:05 AM by rjeschke
Changed on 03/18/2016 at 11:45:18 AM by rjeschke
comment:4 Changed on 03/18/2016 at 11:46:02 AM by rjeschke
Okay, could reproduce this with the Nexus5/Android6, attached crash log just for reference.
comment:5 Changed on 05/10/2016 at 04:13:20 PM by diegocarloslima
- Owner set to diegocarloslima
comment:6 Changed on 05/11/2016 at 02:36:58 PM by diegocarloslima
This crash happens because when PreferenceActivity gets inflated, it tries to read the colorPrimary styling attribute (not the android:colorPrimary one), and since it could find it in the current theme, it throws an exception
comment:7 Changed on 05/11/2016 at 02:53:45 PM by diegocarloslima
- Status changed from new to reviewing
comment:9 Changed on 07/11/2016 at 01:59:22 PM by rjeschke
- Blocking 4237 added
comment:10 Changed on 10/17/2016 at 03:04:16 PM by abpbot
A commit referencing this issue has landed:
Issue 3820 - Selecting Settings within ABB for Android causes the app to crash.
comment:11 Changed on 10/17/2016 at 03:08:33 PM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:12 Changed on 10/17/2016 at 05:49:54 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
comment:13 Changed on 10/17/2016 at 06:06:15 PM by diegocarloslima
- Blocking 2512 added
comment:14 Changed on 06/19/2017 at 12:10:20 PM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
- The app no longer crashes when entering the settings menu.
ABB adblockbrowser-1.1.1.20170612182010-arm
Nexus 5
Android 6.0.1
ABB adblockbrowser-1.1.1.20170612182010-arm
Galaxy S7
Android 7.0
So far no luck reproducing this on my Android 4.4.4 device, currently upgrading my S6 to Android 6.
Will try with my Nexus5/Android 6 in the meantime.