Opened on 04/05/2016 at 12:51:46 PM
Closed on 04/05/2016 at 01:58:22 PM
#3889 closed change (fixed)
Dispatch subscription downloading event instead of downloadStatus when transfer begins
| Reported by: | kzar | Assignee: | kzar |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | trev, sebastian | Blocked By: | |
| Blocking: | #3870 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Background
Subscriptions dispatch a "subscription.downloadStatus" FilterNotifier event both when the begin downloading and when the download has finished. Unfortunately at the moment both have a downloadStatus of "sychronize_ok". (Assuming that it successfully downloaded.)
What to change
The onDownloadStarted hook in lib/synchronizer.js should dispatch a subscription.downloading event instead of a subscription.downloadStatus one.
Attachments (0)
Change History (6)
comment:1 Changed on 04/05/2016 at 12:53:10 PM by kzar
- Blocking 3870 added
comment:2 Changed on 04/05/2016 at 01:03:08 PM by kzar
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 04/05/2016 at 01:21:16 PM by kzar
- Description modified (diff)
- Summary changed from Set downloadStatus for subscriptions to "in_progress" when they begin downloading to Dispatch subscription downloading event instead of downloadStatus when transfer begins
comment:5 Changed on 04/05/2016 at 01:56:59 PM by abpbot
comment:6 Changed on 04/05/2016 at 01:58:22 PM by kzar
- Priority changed from Unknown to P3
- Ready set
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockpluscore/rev/719f4b374d89