Opened on 04/05/2016 at 05:25:06 PM
Closed on 04/06/2016 at 10:59:46 PM
#3890 closed defect (fixed)
Fix downloading indication for subscriptions on new options page
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner, kzar | Blocked By: | |
| Blocking: | #3870 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
The "Donwloading..." indication isn't shown for subscriptions when running in the extension. It is shown using the standalone mock implementation. That is because it artificially changes the lastDownload property when the download is started. However, in the real world, that doesn't happen. Instead the subscription.downloadStatus was dispatched until recently. Since #3889, subscription.downloading is dispatched instead. In both cases no property is actually changed.
What to change
Make sure that the download status on the new options page is updated on subscription.downloading.
Attachments (0)
Change History (6)
comment:1 Changed on 04/05/2016 at 05:26:24 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/06/2016 at 10:43:32 AM by kzar
- Blocking 3870 added
comment:3 Changed on 04/06/2016 at 11:22:12 AM by kzar
- Priority changed from Unknown to P2
comment:4 Changed on 04/06/2016 at 01:59:34 PM by greiner
- Ready set
comment:5 Changed on 04/06/2016 at 10:57:00 PM by abpbot
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplusui/rev/500c80ee5bec
comment:6 Changed on 04/06/2016 at 10:59:46 PM by sebastian
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
(Setting this as P2 as it's blocking a P2 issue.)