Opened on 04/19/2016 at 03:28:13 PM
Closed on 04/19/2016 at 04:03:27 PM
Last modified on 04/25/2016 at 06:31:56 AM
#3957 closed change (fixed)
Update dependency on adblockpluscore to revision 82c88024773b
| Reported by: | trev | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-2.7.3-for-Firefox |
| Module: | Adblock-Plus-for-Firefox | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
We fixed #3879 in Core, this fix needs to be imported into Adblock Plus for Firefox.
This will import additional changes:
- #3862 - Affects how Adblock Plus reacts if filters or subscriptions are changed, corresponding functionality of the first-run page and preferences should be retested.
- #3873 - Shouldn't have any visible changes, affects functionality of filters limited to one domain like foo$domain=example.com.
- https://hg.adblockplus.org/adblockpluscore/rev/74987c2906ac - affects functionality of the anti-adblock warning and setting of the filter list homepage after download.
- #3889 - Affects the display of "downloading" state for subscriptions in Filter Preferences.
- #3952 - Supposedly whitespace only change, shouldn't have any impact on the build.
What to change
Make sure the new events module is imported. Make sure to treat subscription.downloading notification the same as subscription.downloadStatus in Filter Preferences.
Attachments (0)
Change History (4)
comment:1 Changed on 04/19/2016 at 03:39:17 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 04/19/2016 at 04:02:31 PM by abpbot
comment:3 Changed on 04/19/2016 at 04:03:27 PM by trev
- Milestone set to Adblock-Plus-2.7.3-for-Firefox
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 04/25/2016 at 06:31:56 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Changes haven't caused any obvious regressions and functionality like the first-run page and downloading of / download status of subscriptions is working correctly.
ABP 2.7.2.4166
Firefox 38 / 44 / Windows 8
Nightly 48.0a1 (2016-04-19) / Windows 8
Firefox 38 / 44 / OS X 10.11
Firefox 45.01 / Ubuntu 14.04
Nightly 48.0a1 (2016-04-19) / Ubuntu 14.04
A commit referencing this issue has landed:
https://hg.adblockplus.org/adblockplus/rev/f01098554bed