Opened on 04/27/2016 at 08:40:57 AM

Closed on 09/26/2017 at 12:13:02 PM

Last modified on 10/11/2017 at 06:00:16 PM

#3994 closed change (fixed)

Do not register ABB to Androids AccountManager

Reported by: scheer Assignee: jwangenheim
Priority: P4 Milestone: Adblock-Browser-for-Android-1.3.0
Module: Adblock-Browser-for-Android Keywords:
Cc: Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29542628/

Description (last modified by diegocarloslima)

As we removed Firefox Sync (See #2350, #2417, #2474, #2480, #2785) we should not register ABB to Androids AccountManager anymore.

Observed behaviour

Duplications of 'Firefox' (one with the ABB icon and one with the Firefox icon).
Duplications of 'Firefox Sync (deprecated)' (One with the ABB icon and one with the Firefox icon).

Expected behaviour

ABB should not show up in Device Settings -> Account -> Add account anymore.

Attachments (1)

Screenshot_2016-04-27-09-57-00.png​ (222.5 KB) - added by scheer on 04/27/2016 at 08:41:12 AM.

Download all attachments as: .zip

Change History (12)

Changed on 04/27/2016 at 08:41:12 AM by scheer

comment:1 Changed on 04/27/2016 at 08:56:41 AM by scheer

  • Description modified (diff)

comment:2 Changed on 08/16/2017 at 01:24:04 AM by diegocarloslima

  • Priority changed from Unknown to P4

comment:3 Changed on 09/12/2017 at 11:46:24 AM by jwangenheim

  • Description modified (diff)
  • Summary changed from ABB duplicates Firefox and Firefox Sync (deprecated) wording for ABB when adding an account on the device to Do not register ABB into Androids AccountManager
  • Type changed from defect to change

comment:4 Changed on 09/12/2017 at 11:48:05 AM by jwangenheim

  • Summary changed from Do not register ABB into Androids AccountManager to Do not register ABB to Androids AccountManager

comment:5 Changed on 09/12/2017 at 12:28:09 PM by jwangenheim

  • Owner set to jwangenheim

comment:6 Changed on 09/12/2017 at 01:42:45 PM by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:7 Changed on 09/26/2017 at 08:32:31 AM by abpbot

A commit referencing this issue has landed:
​Issue 3994 - Do not register ABB to Androids AccountManager

comment:8 Changed on 09/26/2017 at 12:13:02 PM by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:9 Changed on 09/26/2017 at 02:41:51 PM by diegocarloslima

  • Milestone set to Adblock-Browser-for-Android-next
  • Ready set

comment:10 Changed on 09/28/2017 at 06:41:17 PM by diegocarloslima

  • Description modified (diff)

comment:11 Changed on 10/11/2017 at 06:00:16 PM by traynard

  • Verified working set

Verified in KitKat - Oreo

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jwangenheim.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.