Opened on 05/06/2016 at 10:42:09 PM
Closed on 05/30/2016 at 12:52:04 PM
Last modified on 09/20/2017 at 08:57:32 AM
#4020 closed defect (fixed)
In Edge, rawSender.url is not always defined
| Reported by: | scottlow | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Unknown | Keywords: | |
| Cc: | sebastian, oleksandr | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
There are certain cases where rawSender.url in /ext/background.js is not always defined. As a result, we recommend that the line that reads url: new URL(rawSender.url), actually read url: rawSender.url ? new URL(rawSender.url): '',
Attachments (0)
Change History (11)
comment:1 Changed on 05/07/2016 at 01:31:08 AM by sebastian
- Cc sebastian oleksandr added
comment:2 Changed on 05/09/2016 at 02:22:24 PM by sebastian
comment:3 Changed on 05/09/2016 at 03:57:28 PM by scottlow
The only one I've run into so far is coming from extension-served (ms-browser-extension://) pages. Either way, putting in the null check will ensure there are no failures until we've properly enumerated all cases.
comment:4 Changed on 05/23/2016 at 04:46:29 AM by oleksandr
- Keywords edge added
comment:5 Changed on 05/23/2016 at 04:47:22 AM by oleksandr
- Platform changed from Internet Explorer to Edge
comment:6 Changed on 05/23/2016 at 05:47:06 AM by oleksandr
- Ready set
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:7 Changed on 05/23/2016 at 10:36:25 AM by sebastian
- Keywords edge removed
comment:8 Changed on 05/30/2016 at 12:52:04 PM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
comment:9 Changed on 06/10/2016 at 11:27:49 PM by sebastian
- Sensitive unset
comment:10 Changed on 11/08/2016 at 12:24:23 PM by abpbot
A commit referencing this issue has landed:
Issue 4020 - In Edge, rawSender.url is not always defined
comment:11 Changed on 09/20/2017 at 08:57:32 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Hasn't introduced any issues. I tested this through general use and messing around in extension served pages (first run, options etc.) looking for errors.
ABP 0.9.11.1849
Edge 40 / Windows 10
ABP 1.13.3.1838
Chrome 49 / 61 / Windows 10
Opera 36 / 47 / Windows 10
ABP 2.99.0.1838beta
Firefox 50 / 55 / Windows 10
What are the cases when url isn't given?