Opened on 05/06/2016 at 10:44:43 PM
Closed on 05/28/2016 at 10:51:52 PM
Last modified on 06/10/2016 at 11:27:49 PM
#4021 closed defect (fixed)
The logic that checks for Edge is incorrect in adblockplusedge
| Reported by: | scottlow | Assignee: | |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | Unknown | Keywords: | |
| Cc: | sebastian, oleksandr | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
In the adblockplusedge repository, there is code that checks for Edge by doing the following: if (!("chrome" in window)). Unfortunately, we do have a chrome object, so this is not a suitable differentiator. The logic we recommend instead is if (typeof browser != 'undefined').
Attachments (0)
Change History (7)
comment:1 Changed on 05/07/2016 at 01:30:11 AM by sebastian
- Cc sebastian oleksandr added
- Sensitive set
comment:2 in reply to: ↑ description Changed on 05/09/2016 at 02:28:55 PM by sebastian
comment:3 Changed on 05/23/2016 at 04:48:27 AM by oleksandr
- Keywords edge added
- Platform changed from Internet Explorer to Edge
- Ready set
comment:4 Changed on 05/23/2016 at 05:24:13 AM by oleksandr
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 05/23/2016 at 10:36:25 AM by sebastian
- Keywords edge removed
comment:6 Changed on 05/28/2016 at 10:51:52 PM by oleksandr
- Resolution set to fixed
- Status changed from reviewing to closed
comment:7 Changed on 06/10/2016 at 11:27:49 PM by sebastian
- Sensitive unset
Note: See
TracTickets for help on using
tickets.
We also alias browser to chrome if it doesn't exist. So it seems that fallback wouldn't even be necessary?
Anyway, code that checks for the chrome object aims to detect the availability of the chrome-like extension API (as the same code runs on Safari as well). It seems that code specifically checking for Edge is already checking for the browser object.