Opened on 04/30/2014 at 03:56:41 AM
Closed on 12/11/2014 at 04:59:37 PM
#406 closed change (fixed)
[meta] The $sitekey option should enable/disable specific filters
| Reported by: | fhd | Assignee: | |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Unknown | Keywords: | 2014q3, meta |
| Cc: | trev, greiner | Blocked By: | #431, #432, #433, #434, #698 |
| Blocking: | Platform: | Unknown | |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description (last modified by philll)
Background
Currently, the $sitekey option makes it possible to whitelist everything on a site that has the matching private key. It's the only practicable approach for whitelisting a large number of sites, but easy to abuse.
What to change
| Ticket | Status | Resolution | Summary | Component | Owner |
|---|---|---|---|---|---|
| #431 | closed | fixed | Remove special handling for the $sitekey option | Core | greiner |
| #432 | closed | fixed | Adjust to $sitekey-related changes of the Matcher API (Firefox) | Adblock-Plus-for-Firefox | greiner |
| #433 | closed | fixed | Adjust to $sitekey-related changes of the Matcher API (Platform) | Platform | greiner |
| #434 | closed | fixed | Document $sitekey functionality | Websites | greiner |
| #698 | closed | fixed | Create tests for $sitekey option | Extensions-for-Adblock-Plus | greiner |
Attachments (0)
Change History (17)
comment:1 Changed on 04/30/2014 at 03:57:47 AM by fhd
- Cc trev added
comment:2 Changed on 04/30/2014 at 06:34:33 AM by trev
- Description modified (diff)
- Ready set
Changed description to make it more clear. And - yes, this should be a meta issue. There are three parts here: Core, Platform and documentation.
comment:3 Changed on 05/02/2014 at 12:03:26 PM by fhd
Can you create the Core/Platform issues for this Wladimir? I think you've got a much better idea of what in particular we need to change in each case. Also note that Platform currently only covers Chrome/Opera/Safari code, meaning we'll also need a Firefox issue if this cannot be changed in Core alone.
comment:4 Changed on 05/05/2014 at 07:38:26 AM by greiner
- Cc greiner added
comment:5 Changed on 05/05/2014 at 11:22:01 AM by fhd
- Priority changed from P3 to P1
Increasing priority, we should get this sorted out as soon as possible.
comment:6 Changed on 05/06/2014 at 09:13:07 AM by trev
- Blocked By 431 added
comment:7 Changed on 05/06/2014 at 10:19:30 AM by trev
- Blocked By 432 added
comment:8 Changed on 05/06/2014 at 10:27:13 AM by trev
- Blocked By 433 added
comment:9 Changed on 05/06/2014 at 10:30:28 AM by trev
- Blocked By 434 added
comment:10 Changed on 05/06/2014 at 10:32:07 AM by trev
- Description modified (diff)
comment:11 Changed on 05/06/2014 at 11:31:02 AM by fhd
- Component changed from Core to Unknown
- Summary changed from The $sitekey option should enable/disable specific filters to [meta] The $sitekey option should enable/disable specific filters
comment:12 Changed on 05/21/2014 at 07:19:46 PM by trev
- Keywords meta added
comment:13 Changed on 05/22/2014 at 01:15:11 PM by philll
- Description modified (diff)
- Keywords 2014q3 added
comment:14 Changed on 05/28/2014 at 05:25:28 AM by fhd
- Priority changed from P1 to P2
Reducing priority again, this is planned and not a real blocker.
comment:15 Changed on 06/23/2014 at 04:08:55 PM by greiner
- Blocked By 698 added
comment:16 Changed on 11/21/2014 at 01:04:35 PM by sven
- Keywords changed from meta,2014q3 to 2014q3, meta
- Platform set to Unknown
comment:17 Changed on 12/11/2014 at 04:59:37 PM by greiner
- Resolution set to fixed
- Status changed from new to closed
Wladimir, can you go over this and set to ready when you're happy with it?
It looks to me like this can be addressed in Core. If it needs platform specific work, we should turn it into a meta issue.