Opened on 06/23/2014 at 04:08:55 PM
Closed on 12/11/2014 at 04:57:32 PM
Last modified on 05/20/2015 at 02:22:39 PM
#698 closed change (fixed)
Create tests for $sitekey option
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Extensions-for-Adblock-Plus | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #406, #1687 | Platform: | Firefox |
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): | |||
Description
Background
We have been using the $sitekey option for whitelisting multiple domains at once and will extend it with #431. So far tests for verifying the signature only exist in adblockpluschrome.
What to change
Add tests to the following test modules:
- filterClasses
- matcher
- regexFilters_matching
- policy
Additionally, include the "signatures" module from adblockpluschrome to test the signature verification.
Attachments (0)
Change History (5)
comment:1 Changed on 09/02/2014 at 02:09:03 PM by greiner
- Component changed from Extensions-for-Adblock-Plus to Adblock-Plus-for-Firefox
- Platform set to Firefox/Firefox Mobile
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 12/11/2014 at 02:09:45 PM by greiner
- Blocking 1687 added
comment:3 Changed on 12/11/2014 at 04:57:32 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 03/10/2015 at 02:01:02 PM by trev
- Component changed from Adblock-Plus-for-Firefox to Extensions-for-Adblock-Plus
comment:5 Changed on 05/20/2015 at 02:22:39 PM by philll
- Platform changed from Firefox/Firefox Mobile to Firefox
Made Firefox and Firefox mobile available as seperate platforms.
Note: See
TracTickets for help on using
tickets.
Fixed: https://hg.adblockplus.org/adblockplustests/rev/30c3c8f9f80c