Opened on 05/29/2016 at 02:14:51 AM

Closed on 08/29/2017 at 04:04:50 PM

Last modified on 10/08/2019 at 05:47:40 PM

#4084 closed change (fixed)

Do not use @@bidi_dir directly in adblockplusui

Reported by: oleksandr Assignee:
Priority: Unknown Milestone:
Module: User-Interface Keywords:
Cc: greiner, sebastian Blocked By:
Blocking: #3697 Platform: Unknown / Cross platform
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29345232/

Description

Background

We have refactored the background page code in #3697. We should not use the @@bidi_dir directly now, and instead rely on Utils.readingDirection.

What to change

Replace calls of @@bidi_dir with Utils.readingDirection.

Attachments (0)

Change History (5)

comment:1 Changed on 05/29/2016 at 02:17:11 AM by oleksandr

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 08/29/2017 at 12:28:00 PM by abpbot

A commit referencing this issue has landed:
​Issue 4084 - Do not pretent to support getMessage for @@ui_locale and @@bidi_dir

comment:3 Changed on 08/29/2017 at 12:54:52 PM by sebastian

  • Blocking 3697 added

comment:4 Changed on 08/29/2017 at 04:04:50 PM by oleksandr

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 06/21/2019 at 05:58:37 AM by modifaku

spam

Last edited on 10/08/2019 at 05:47:40 PM by kzar

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.