Opened on 06/09/2016 at 10:29:16 AM

Closed on 06/10/2016 at 09:40:41 PM

#4142 closed change (fixed)

Update ABP icon in FF toolbar to support for high resolution screens

Reported by: juliandoucette Assignee: trev
Priority: P3 Milestone: Adblock-Plus-2.8-for-Firefox
Module: Adblock-Plus-for-Firefox Keywords: icon, logo, toolbar
Cc: trev Blocked By:
Blocking: Platform: Firefox
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29345731/

Description (last modified by trev)

Background

The ABP logo in the FF toolbar looks distorted on high-res screens.

What to change

Package both an icon for low-res and one for high-res screens, use whichever is more appropriate.

Attachments (1)

ff-abp-toolbar.PNG (11.0 KB) - added by juliandoucette on 06/09/2016 at 10:29:54 AM.
ABP logo on high res screen 2016/06/09

Download all attachments as: .zip

Change History (7)

Changed on 06/09/2016 at 10:29:54 AM by juliandoucette

ABP logo on high res screen 2016/06/09

comment:1 Changed on 06/09/2016 at 01:54:33 PM by trev

  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 06/09/2016 at 02:13:11 PM by trev

  • Owner set to trev

comment:3 Changed on 06/09/2016 at 02:29:04 PM by trev

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

Found a way to do this for the 16x16 icon, for the larger version (e.g. when the ABP icon is inside the "hamburger menu" in Firefox) we will need new images.

comment:4 Changed on 06/09/2016 at 02:58:01 PM by trev

For reference, this has no effect on SeaMonkey on OS X (don't know about Windows) - it runs in low-res mode and isn't aware of high resolution screens.

comment:5 Changed on 06/10/2016 at 09:35:07 PM by abpbot

comment:6 Changed on 06/10/2016 at 09:40:41 PM by trev

  • Milestone set to Adblock-Plus-for-Firefox-next
  • Resolution set to fixed
  • Status changed from reviewing to closed

I filed #4147 to follow up on the larger icon.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from trev.
 
Note: See TracTickets for help on using tickets.