Opened on 06/09/2016 at 08:54:56 AM
Closed on 06/09/2016 at 08:27:41 PM
Last modified on 06/27/2016 at 01:13:13 PM
#4141 closed defect (fixed)
Video ads on YouTube not blocked
| Reported by: | arthur | Assignee: | trev |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Plus-1.12.1-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | kzar, sebastian, TobiasHilleke, trev | Blocked By: | |
| Blocking: | #3687 | Platform: | Safari |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by trev)
Environment
- Safari 7.1.8
- OSX 10.9.5
- ABP 1.12
- EasyList and Acceptable Ads
Also reproducible on newer Safari versions after running the following from the command line:
defaults write com.apple.Safari CustomUserAgent "\"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9) AppleWebKit/537.71 (KHTML, like Gecko) Version/7.0 Safari/537.71\""
Right-click the video on YouTube to verify that you see the Flash video player and not the HTML5 one. This change can be undone using the following command:
defaults delete com.apple.Safari CustomUserAgent
How to reproduce
- Open https://www.youtube.com/watch?v=0HGenoCF8Js or https://www.youtube.com/watch?v=guHKf6GxqTw&feature=youtu.be
- (might need to test with other videos from the sidebar)
Observed behaviour
Video ad appearing before the video (served via Flash).
Expected behaviour
Video ads should be blocked.
Attachments (0)
Change History (10)
comment:1 Changed on 06/09/2016 at 09:55:58 AM by mapx
- Cc kzar sebastian added
comment:2 Changed on 06/09/2016 at 12:37:13 PM by arthur
- Cc TobiasHilleke added
- Description modified (diff)
comment:3 Changed on 06/09/2016 at 04:13:58 PM by sebastian
- Cc trev added
comment:4 Changed on 06/09/2016 at 05:21:12 PM by trev
- Component changed from Unknown to Platform
- Priority changed from Unknown to P1
- Ready set
comment:5 Changed on 06/09/2016 at 05:27:53 PM by trev
- Blocking 3687 added
- Owner set to trev
This is fallout from #3687.
comment:6 Changed on 06/09/2016 at 05:30:00 PM by trev
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:8 Changed on 06/09/2016 at 08:27:05 PM by abpbot
A commit referencing this issue has landed:
Issue 4141 - Safari: Fixed blocking of video ads on YouTube
comment:9 Changed on 06/09/2016 at 08:27:41 PM by trev
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 06/27/2016 at 01:13:13 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Adverts no longer play before the video when the Flash player is used in Safari.
ABP 1.12.0.1622
Safari 7 / OS X 10.9
I can confirm this issue in Safari 9.1.1. However, the important keyword here is "flash" - it doesn't affect the HTML5 player, only the legacy Flash player. In order to get the Flash player I had to change Safari's user agent:
This will cause YouTube to show the Flash video player and it will play an advertisement for these videos. Adblock Plus 1.11 is fine, only Adblock Plus 1.12 shows this behavior.