Opened on 06/15/2016 at 02:34:16 PM

Closed on 01/25/2017 at 03:09:30 PM

Last modified on 01/30/2017 at 10:50:27 AM

#4155 closed change (rejected)

Create global csscomb config

Reported by: juliandoucette Assignee: juliandoucette
Priority: Unknown Milestone:
Module: Sitescripts Keywords:
Cc: fhd, saroyanm, greiner, trev, erikvold Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29346536/

Description

Background

SScomb is a coding style formatter for CSS. You can easily write your own configuration to make your style sheets beautiful and consistent.

The main feature is sorting properties in a specific order. It was inspired by @miripiruni's PHP-based tool of the same name. This is the new JavaScript version, based on the powerful CSS parser Gonzales PE.

We can use this tool with our favorite editors (via plugin) or integrate it into our build procedures to auto-format our CSS and avoid style guide issues in review.

What to change

Add global .csscomb.json to codingtools repository

Attachments (0)

Change History (2)

comment:1 Changed on 01/25/2017 at 03:09:30 PM by juliandoucette

  • Resolution set to rejected
  • Status changed from new to closed

comment:2 Changed on 01/30/2017 at 10:50:27 AM by juliandoucette

I closed this ticket/review because:

  • stylelint covers more relevant rules
  • stylelint handles sass/scss better (which was not a requirement when this

ticket was created)

  • csscomb seems less configurable as a linter (which is useful for CI)
  • stylefmt covers formatting for stylelint
  • stylelint is more actively maintained
  • stylelint seems to have better editor plugins

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from juliandoucette.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.