Opened on 06/15/2016 at 04:37:33 PM
Closed on 08/22/2016 at 08:19:59 AM
#4156 closed defect (fixed)
Removing the item from the advanced tab doesn't remove item in General tag
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Chrome: 51.0.2704.84
How to reproduce
- Navigate to advanced tab
- Remove Easylist from the drop down
- Navigate to General tab
- Observe
Observed behaviour
Easylist is still is not removed
Expected behaviour
Easylist is removed from the General tab as well
Attachments (0)
Change History (6)
comment:1 Changed on 06/15/2016 at 04:39:17 PM by saroyanm
comment:2 Changed on 06/15/2016 at 04:46:31 PM by greiner
- Priority changed from Unknown to P2
- Ready set
I was able to reproduce this issue.
comment:3 Changed on 06/15/2016 at 05:48:29 PM by saroyanm
- Owner set to saroyanm
comment:4 Changed on 06/15/2016 at 05:48:48 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 08/22/2016 at 08:18:34 AM by abpbot
A commit referencing this issue has landed:
Issue 4156 - removing item from the advanced tab doesn't remove it from the General tab
comment:6 Changed on 08/22/2016 at 08:19:59 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Please note that this issue doesn't only affect only deletion.
We currently checking if subscription is recommended in some places in the code, but we need to check if the "KnownFilter" is recommended or not, while added subscription item missing some info that we are keeping in "subscriptionsMap".
I'll suggest to update the subscriptin with the required information(properties from the "Knownsubscription") in "onSubscriptionMessage" because currently we are doing that not centralized probably one of the reasons why we missed this.