Opened on 06/16/2016 at 10:54:37 AM
Closed on 09/15/2016 at 11:44:42 AM
#4160 closed defect (fixed)
Return headers in AndroidWebRequest
Reported by: | asmirnov | Assignee: | asmirnov |
---|---|---|---|
Priority: | P3 | Milestone: | |
Module: | Libadblockplus-Android | Keywords: | |
Cc: | rjeschke | Blocked By: | |
Blocking: | #4031, #4209 | Platform: | Android |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Currently AndroidWebRequest (https://hg.adblockplus.org/libadblockplus-android/file/tip/libadblockplus-android/src/org/adblockplus/android/AndroidWebRequest.java) is not returning headers and some tests fail (similar test for java - https://hg.adblockplus.org/libadblockplus/file/tip/test/WebRequest.cpp#l78). For this headers mapping should be implemented in jni part too (https://hg.adblockplus.org/libadblockplus-android/file/fb8d6100e93b/libadblockplus-android/jni/JniWebRequest.cpp#l80) and fix https://codereview.adblockplus.org/29345369/diff/29345370/libadblockplus-android/jni/JniWebRequest.cpp
Attachments (0)
Change History (5)
comment:1 Changed on 06/16/2016 at 10:56:57 AM by asmirnov
- Cc rjeschke added
comment:2 Changed on 06/16/2016 at 11:10:13 AM by asmirnov
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 06/30/2016 at 11:57:38 AM by asmirnov
- Blocking 4209 added
comment:4 Changed on 09/15/2016 at 11:44:02 AM by abpbot
comment:5 Changed on 09/15/2016 at 11:44:42 AM by asmirnov
- Resolution set to fixed
- Status changed from reviewing to closed
A commit referencing this issue has landed:
Issue 4160 - Return headers in AndroidWebRequest