Opened on 05/10/2016 at 12:33:02 PM

Closed on 10/23/2018 at 10:25:28 AM

#4031 closed change (fixed)

Implement tests for libadblockplus-android

Reported by:	rjeschke	Assignee:	asmirnov
Priority:	P3	Milestone:
Module:	Libadblockplus-Android	Keywords:
Cc:	sergz	Blocked By:	#4030, #4160, #4176, #4177, #4178
Blocking:	#4080, #4081, #4086, #4146, #4180, #4181	Platform:	Android
Ready:	yes	Confidential:	no
Tester:	Unknown	Verified working:	no
Review URL(s):	https://codereview.adblockplus.org/29344967/

Description

Background

We need to set up tests for the new libadblockplus-android project.

What to change

Write tests that focus on testing the JNI bindings, i.e. the Java side, as the functional side is covered by `libadblockplus`. Having a basic testing of the underlying functionality shouldn't be removed completely, as those can also indicate a problem in the glue code.

Change History (20)

comment:1 Changed on 05/11/2016 at 10:38:00 AM by Anton

Owner set to Anton

comment:2 Changed on 05/12/2016 at 11:15:35 AM by asmirnov

Owner changed from Anton to asmirnov

comment:3 Changed on 05/17/2016 at 02:25:51 PM by sergz

Cc sergz added

comment:4 Changed on 05/19/2016 at 12:32:13 PM by rjeschke

Component changed from Libadblockplus to Libadblockplus-Android

comment:5 Changed on 05/23/2016 at 08:34:24 AM by philll

Summary changed from Implement tests to Implement tests for libadblockplus-android

comment:6 Changed on 05/27/2016 at 01:58:49 PM by asmirnov

Blocking 4080 added

comment:7 Changed on 05/27/2016 at 02:06:41 PM by asmirnov

Blocking 4081 added

comment:8 Changed on 05/30/2016 at 10:55:15 AM by asmirnov

Blocking 4086 added

comment:9 Changed on 06/10/2016 at 10:37:39 AM by asmirnov

Blocking 4146 added

comment:10 Changed on 06/10/2016 at 10:39:58 AM by asmirnov

Status changed from new to reviewing

comment:11 Changed on 06/10/2016 at 10:48:13 AM by asmirnov

Review URL(s) modified (diff)

comment:12 Changed on 06/16/2016 at 10:54:37 AM by asmirnov

Blocked By 4160 added

comment:13 Changed on 06/21/2016 at 01:32:56 PM by asmirnov

Blocked By 4176 added

comment:14 Changed on 06/21/2016 at 01:36:32 PM by asmirnov

Blocked By 4177 added

comment:15 Changed on 06/21/2016 at 01:56:22 PM by asmirnov

Blocked By 4178 added

comment:16 Changed on 06/21/2016 at 03:31:00 PM by abpbot

A commit referencing this issue has landed:
Issue 4031 - Implement tests for libadblockplus-android

comment:17 Changed on 06/22/2016 at 07:54:38 AM by asmirnov

Blocking 4180 added

comment:18 Changed on 06/22/2016 at 08:03:23 AM by asmirnov

Blocking 4181 added

comment:19 Changed on 09/16/2016 at 07:10:57 AM by abpbot