Opened on 06/17/2016 at 11:47:24 AM
Closed on 06/17/2016 at 01:19:21 PM
Last modified on 06/20/2016 at 12:03:54 PM
#4166 closed defect (fixed)
ABB crashes when having to many active filters lists
| Reported by: | scheer | Assignee: | |
|---|---|---|---|
| Priority: | P1 | Milestone: | Adblock-Browser-for-iOS-1.4.0 |
| Module: | Adblock-Browser-for-iOS | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for iOS | |
| Ready: | yes | Confidential: | no |
| Tester: | Scheer | Verified working: | yes |
| Review URL(s): | |||
Description
When the user activates too many (c.a 10) filter lists, ABB crashes and then crashes each time the user attempts to re-launch the app.
The same behaviour can be invoked when the user has the normal English easylist installed and adds 1 additional easylist language, so that there are never more than two lists active at any time. Then, replaces the newly added list with another language. After repeating this step the 7th or 8th list added creates the same crash.
Environment
ABB 1.4.0-qa (1038)
iPhone 6 Plus
iOS 9.3.1
AA Enabled
All 'More blocking options' are disabled
URL search suggestions are Off
How to reproduce
- Add as many filter lists as you can
OR
- Have the default English Easylist active
- Add the first available filter list
- Wait three to four seconds
- Disable the filter list added in step 2
- Add the next available filter list
- Continue to repeat steps 2-5
Observed behaviour
ABB crashes and upon trying to relaunch the app, it either instantly crashes again or loads to the Bookmarks screen and then crashes again.
Expected behaviour
Adding filter lists should not crash ABB.
Attachments (1)
Change History (6)
Changed on 06/17/2016 at 11:47:32 AM by scheer
comment:1 Changed on 06/17/2016 at 12:31:39 PM by scheer
- Milestone set to Adblock-Browser-for-iOS-1.4.0
comment:2 Changed on 06/17/2016 at 01:18:09 PM by mario
- Ready set
comment:3 Changed on 06/17/2016 at 01:19:21 PM by pavelz
- Resolution set to fixed
- Status changed from new to closed
comment:4 Changed on 06/20/2016 at 08:48:48 AM by scheer
- Tester changed from Unknown to Scheer
- Verified working set
I am no longer able to crash ABB with the steps provided above.
ABB 1.4.0 (1043)
iPhone 6 Plus
iOS 9.3.1
comment:5 Changed on 06/20/2016 at 12:03:54 PM by mario
- Priority changed from Unknown to P1
Fixed in 1.4.0 qa build 1043 by merging chrome.storage fix from develop listed in https://issues.adblockplus.org/ticket/4012