Opened on 06/17/2016 at 02:43:29 PM
Closed on 09/27/2016 at 03:05:28 PM
Last modified on 09/27/2016 at 03:16:27 PM
#4167 closed change (fixed)
Update ElemHide APIs to allow Firefox to be switched to per-site stylesheets
| Reported by: | trev | Assignee: | kzar |
|---|---|---|---|
| Priority: | P4 | Milestone: | |
| Module: | Core | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #524, #4477 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
In #524 we want to split up the current singular stylesheet into per-domain rules and rules that are always applied. ElemHide APIs need to be adjusted for that.
What to change
- Remove usingGetSelectorsForDomain flag - all implementations will need ElemHide.getSelectorsForDomain() API now.
- Replace ElemHide.getSelectors() by Elemhide.getUnconditionalSelectors() which should essentially return the value of unconditionalSelectors variable.
- Add an additional parameter noUnconditional to ElemHide.getSelectorsForDomain() - unconditionalSelectors should only be considered if that flag isn't set.
Attachments (0)
Change History (6)
comment:2 Changed on 09/27/2016 at 02:54:20 PM by abpbot
comment:3 Changed on 09/27/2016 at 03:02:58 PM by abpbot
A commit referencing this issue has landed:
Issue 4167 - Fixed getUnconditionalFilterKeys comment
comment:4 Changed on 09/27/2016 at 03:05:28 PM by kzar
- Resolution set to fixed
- Status changed from new to closed
comment:5 Changed on 09/27/2016 at 03:06:15 PM by kzar
- Cc kzar removed
- Owner set to kzar
comment:6 Changed on 09/27/2016 at 03:16:27 PM by kzar
- Blocking 4477 added
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 4167 - getSelectorsForDomain criteria + keys