Opened on 05/02/2014 at 01:58:21 PM
Closed on 05/27/2014 at 03:18:21 PM
#417 closed change (fixed)
Re-initializing removed filterlists in Chrome
| Reported by: | jobp | Assignee: | greiner |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-1.8.3-for-Chrome-Opera-Safari |
| Module: | Platform | Keywords: | |
| Cc: | greiner, smultron45@gmail.com | Blocked By: | |
| Blocking: | Platform: | ||
| Ready: | yes | Confidential: | no |
| Tester: | Verified working: | no | |
| Review URL(s): |
http://codereview.adblockplus.org/5450822905233408/ |
||
Description (last modified by greiner)
Background
The removal of the filterlists in Chrome over the last months, is still leaving a significant part of the ABP for Chrome userbase without any filterlists. These users are exposed to ads, while having ABP enabled.
What to change
To protect those users exposed to annoying ads due to this issue, we should reinitialize the filterlists for them. The implementation looks like this:
- On startup check whether patterns.ini is empty (size is zero)
- If that is the case execute the first-run actions
- Show the first-run page containing a message to inform the user about the issue and the actions we took
Attachments (0)
Change History (12)
comment:1 Changed on 05/02/2014 at 03:29:19 PM by mapx
- Cc smultron45@gmail.com added
comment:2 Changed on 05/02/2014 at 03:44:49 PM by jobp
comment:3 Changed on 05/20/2014 at 10:34:44 AM by fhd
- Priority changed from Unknown to P2
This should have been fixed by #361, but apparently it's not :(
Thomas, can you shed some light on this?
comment:4 Changed on 05/20/2014 at 11:05:29 AM by greiner
comment:5 Changed on 05/20/2014 at 12:39:22 PM by philll
As far as I can remember, our latest agreement was on a notification in case of no filter active, asking the user, whether we should reset the application defaults with a filter list matching his language.
comment:6 Changed on 05/20/2014 at 03:56:40 PM by greiner
After discussing this in the intraforum and on IRC we agreed on the following implementation:
- On startup check whether patterns.ini is empty (size is zero)
- If that is the case execute the first-run actions
- Show the first-run page containing a message to inform the user about the issue and the actions we took
comment:7 Changed on 05/21/2014 at 01:05:29 PM by greiner
- Owner set to greiner
- Ready set
comment:8 Changed on 05/26/2014 at 01:34:04 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:9 Changed on 05/26/2014 at 01:45:23 PM by philll
@greiner: please ensure the actually implemented feature set to be written down in the what to change section.
comment:10 Changed on 05/26/2014 at 01:45:34 PM by philll
- Ready unset
comment:11 Changed on 05/26/2014 at 01:51:44 PM by greiner
- Description modified (diff)
- Ready set
comment:12 Changed on 05/27/2014 at 03:18:21 PM by greiner
- Milestone set to Adblock-Plus-for-Chrome-Opera-Safari-next
- Resolution set to fixed
- Status changed from reviewing to closed
Never mind, heard from @fhd that this is already taken care of.